-
Notifications
You must be signed in to change notification settings - Fork 37
Remove lower bound version on cpp-argparse environment-dev.yml #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lower bound version on cpp-argparse environment-dev.yml #271
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
=======================================
Coverage 81.78% 81.78%
=======================================
Files 20 20
Lines 950 950
Branches 87 87
=======================================
Hits 777 777
Misses 173 173 🚀 New features to boost your workflow:
|
Hmm, I guess we don't need anything. We don't have any bound on our feedstock https://github.com/conda-forge/xeus-cpp-feedstock/blob/main/recipe/meta.yaml#L30 If we think any update would bring any failure (like any deprecation or anything) |
Let's just remove any bound on argparse from everywhere https://github.com/search?q=repo%3Acompiler-research%2Fxeus-cpp%20%3E%3D3.0%2C%3C4.0&type=code |
0ee741c
to
cc64083
Compare
@anutosh491 I've applied your suggestion, and the PR is ready for another review |
Perfect, let's move it in ! |
cc64083
to
786affd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@SylvainCorlay can you provide some insight as to whether this table in the Readme is truly needed? In this PR I am trying to make is so we are equivalent for the native build and the emscripten build, in having no pinning of cpp-argparse. Initially I removed cpp-argparse from the table since it is no longer restrained. @anutosh491 believes it should be kept in. I feel the table is not partiular very useful, as I feel its unlikely we are going to want people to go back and build old versions, and if they are they could just use the environment file in the release. I think its best removed, but looking for your opinion on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good ;)
Let's release !
Description
Please include a summary of changes, motivation and context for this PR.
Conda will automatically pick the most recent release of cpp-argparse it can. Therefore the lower bound is not necessary in the yml file. We just need to make sure we don't pick a version 4 release when it happens in case we are not compatible with it.
Fixes # (issue)
Type of change
Please tick all options which are relevant.