Remove lower bound on xeus-zmq version environment-dev.yml #272
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
=======================================
Coverage 80.54% 80.54%
=======================================
Files 19 19
Lines 956 956
Branches 88 88
=======================================
Hits 770 770
Misses 186 186 🚀 New features to boost your workflow:
|
|
Hmmm xeus 5 needs minimum xeus-zmq 3, not sure this should be changed. Xeus 5 and above won't be compatible with anything less than 3 so this looks just fine to me |
Just a point that it's not explicitly needed to state a minimum version of 3 in the yml file, because conda will pick up the latest version it can (which will be greater than 3). This is evident by the ci passing. You just need to make sure it doesn't pick a version 4 of the package, given you may not be compatible (the reason to keep the upper bound). |
|
Cool, you're not wrong (I just like keeping stuff consistent with the feedstock which maintains >3<4) let's take is in. |
Description
Please include a summary of changes, motivation and context for this PR.
Conda will automatically pick the most recent release of xeus-zmq it can. Therefore the lower bound is not necessary in the yml file. We just need to make sure we don't pick a version 4 release when it happens in case we are not compatible with it.
Fixes # (issue)
Type of change
Please tick all options which are relevant.