-
Notifications
You must be signed in to change notification settings - Fork 36
Added tests for xinspect #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
==========================================
+ Coverage 80.87% 82.15% +1.27%
==========================================
Files 20 20
Lines 957 958 +1
Branches 88 88
==========================================
+ Hits 774 787 +13
+ Misses 183 171 -12
🚀 New features to boost your workflow:
|
clang-tidy review says "All clean, LGTM! 👍" |
@anutosh491 This is not something that I can change. The format of I think this is how it is supposed to work. PR is complete from my side. |
92a2397
to
6dc6e14
Compare
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Coverage goes up. Works with lite too so no complaints. Thanks.
xcpp::interpreter interpreter((int)Args.size(), Args.data()); | ||
|
||
std::string code = "?std::vector.push_back"; | ||
std::string inspect_result = "https://en.cppreference.com/w/cpp/container/vector/push_back"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we require internet connection for this test to work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
Description
fetch_documentation_of_member_or_parameter
andis_inspect_request
.inspect
function. (Previously, one can't fetch documentation of member functions and variables.)Fixes #276