Skip to content

Pinning nlohmann_json version for xeus-cpp-lite #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2025
Merged

Conversation

anutosh491
Copy link
Collaborator

Description

nlohmann_json 3.12.0 was out this week and the current xeus version is only compatible with 3.11.* due to reasons mentioned here

https://github.com/jupyter-xeus/xeus/blob/055829bb0cccd1c5afe904a222c33770d98ef860/CMakeLists.txt#L78-L83

So we have the dependency pinned for our native builds

- nlohmann_json=3.11.3

But not for our lite build (So possibly our nightly build should show the error by today/tomorrow when micromamba would pick up 3.12.0 instead of 3.11.3)

I tried the same on my local fork and we would see this error https://github.com/anutosh491/xeus-cpp/actions/runs/14429314765/job/40462192706?pr=8

So pinning it to avoid any errors in the future.

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.56%. Comparing base (d7699c0) to head (b288ad8).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #286   +/-   ##
=======================================
  Coverage   80.56%   80.56%           
=======================================
  Files          20       20           
  Lines         957      957           
  Branches       88       88           
=======================================
  Hits          771      771           
  Misses        186      186           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcbarton mcbarton merged commit 9458ebe into main Apr 13, 2025
14 checks passed
@anutosh491 anutosh491 deleted the anutosh491-patch-1 branch April 13, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants