Pinning nlohmann_json version for xeus-cpp-lite #286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nlohmann_json
3.12.0
was out this week and the current xeus version is only compatible with3.11.*
due to reasons mentioned herehttps://github.com/jupyter-xeus/xeus/blob/055829bb0cccd1c5afe904a222c33770d98ef860/CMakeLists.txt#L78-L83
So we have the dependency pinned for our native builds
xeus-cpp/environment-dev.yml
Line 12 in d7699c0
But not for our lite build (So possibly our nightly build should show the error by today/tomorrow when micromamba would pick up 3.12.0 instead of 3.11.3)
I tried the same on my local fork and we would see this error https://github.com/anutosh491/xeus-cpp/actions/runs/14429314765/job/40462192706?pr=8
So pinning it to avoid any errors in the future.
Please tick all options which are relevant.