Skip to content

Add std::cin cells to example notebooks #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Jun 3, 2025

Description

Please include a summary of changes, motivation and context for this PR.

After #328 std::cin should work for xeus-cpp, so this adds this to the example notebooks.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (84b0619) to head (046c493).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files          20       20           
  Lines         950      950           
  Branches       87       87           
=======================================
  Hits          777      777           
  Misses        173      173           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anutosh491
Copy link
Collaborator

Something looks off here (probably in both cases)

image

So you've added the cells but not rerun the notebook as such so the configuration stands broken and we can't even see the input box when we do std::cin

@anutosh491
Copy link
Collaborator

Also does it really have to be +900-500 change diff to add 2 cells ? Looks a bit too much :\

@mcbarton mcbarton force-pushed the Add-stdcin-to-example-notebooks branch from 5bde6eb to 4d5e775 Compare June 3, 2025 10:18
@anutosh491
Copy link
Collaborator

Also not sure what spoiled this

image

But let's take this opportunity to fix this cell too. We would need to split this into 2 markdown cells so that it is framed correctly

image

@SylvainCorlay
Copy link
Collaborator

Since std::cin interupts the execution of code (preventing a run-all action to complete), maybe we should do it at the very end of the notebook, or just mention it in the markdown cell?

@mcbarton mcbarton force-pushed the Add-stdcin-to-example-notebooks branch 2 times, most recently from 8afabe7 to 7db0f4d Compare June 3, 2025 12:57
@mcbarton mcbarton force-pushed the Add-stdcin-to-example-notebooks branch from 7db0f4d to 046c493 Compare June 3, 2025 12:58
@mcbarton
Copy link
Collaborator Author

mcbarton commented Jun 3, 2025

@SylvainCorlay @anutosh491 your comments have been addressed. This PR is ready for another review.

@SylvainCorlay SylvainCorlay merged commit a0b21c5 into compiler-research:main Jun 3, 2025
14 checks passed
@SylvainCorlay
Copy link
Collaborator

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants