Skip to content

Switch to a shared xeus for the emscripten build #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 6, 2025

Conversation

anutosh491
Copy link
Collaborator

Description

The main motivation here is to enable support for jupyter widgets

image

The above would fail while using a static xeus build because the comm registry in xeus is a singleton and won't work well if we use a static build for xeus.

image

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@anutosh491
Copy link
Collaborator Author

Hey @SylvainCorlay,

Now that jupyterlite-xeus 4.0.1 is out, if we have

    "shared": {
 +   "libxeus.so": "lib/libxeus.so",
      "libclangCppInterOp.so": "lib/libclangCppInterOp.so"
    }

We would get

(xeus-lite-host) anutosh491@Anutoshs-MacBook-Air build % jupyter lite build --XeusAddon.prefix=$PREFIX
static:jupyter-lite.json
.  pre_status:static:jupyter-lite.json
    tarball:         jupyterlite-app-0.6.0.tgz 15MB
    output:          /Users/anutosh491/work/xeus-cpp/build/_output
    lite dir:        /Users/anutosh491/work/xeus-cpp/build
    apps:            
    sourcemaps:      True
    unused packages: True
archive:archive
contents:contents
icons:icons
lite:jupyter-lite.json
mimetypes:jupyter-lite.json
serve:contents
settings:overrides
translation:translation
.  status:archive:archive
[LiteBuildApp] No archive (yet): build-jupyterlite.tgz
.  status:contents:contents
    contents: 0 files
.  status:icons:icons
    favicon files: 7 files
.  status:lite:jupyter-lite.json
[LiteBuildApp]     jupyter-lite.(json|ipynb): 0 files
.  status:mimetypes:jupyter-lite.json
    filetypes:         26 
.  status:serve:contents
    url: http://127.0.0.1:8000/
    server: tornado
    headers:
.  status:settings:overrides
    overrides.json: 0
.  status:translation:translation
    translation files: 2 files
static:output_dir
-- pre_init:static:output_dir
static:unpack
-- init:static:unpack
federated_extensions:copy:ext:jupyterlab_pygments
federated_extensions:copy:ext:@jupyterlite/xeus-extension
-- pre_build:federated_extensions:copy:ext:jupyterlab_pygments
-- pre_build:federated_extensions:copy:ext:@jupyterlite/xeus-extension
icons:copy
/Users/anutosh491/micromamba/envs/xeus-lite-host/lib/python3.13/site-packages/jupyterlite_core/addons/translation.py:89: UserWarning: [lite] [translation] install `jupyterlab_server` to load translations: No module named 'jupyterlab_server'
  if not self.is_sys_prefix_ignored() and has_optional_dependency(
translation:copy
.  build:icons:copy
-- build:translation:copy
federated_extensions:patch
federated_extensions:settings
jupyterlite-xeus:copy:xeus-cpp-wasm-host:xcpp23:logo-64x64.png
jupyterlite-xeus:copy:xeus-cpp-wasm-host:xcpp23:logo-32x32.png
jupyterlite-xeus:copy:xeus-cpp-wasm-host:xcpp23:logo-svg.svg
jupyterlite-xeus:copy:xeus-cpp-wasm-host:xcpp23:libxeus.so
jupyterlite-xeus:copy:xeus-cpp-wasm-host:xcpp23:libclangCppInterOp.so
jupyterlite-xeus:copy:xeus-cpp-wasm-host:xcpp23:libxeus.so
########################################
Execution aborted.
Task generation 'post_build' has duplicated definition of 'post_build:jupyterlite-xeus:copy:xeus-cpp-wasm-host:xcpp23:libxeus.so'

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (c0d4edc) to head (72ee473).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #334   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files          20       20           
  Lines         950      950           
  Branches       87       87           
=======================================
  Hits          777      777           
  Misses        173      173           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcbarton mcbarton requested a review from vgvassilev June 5, 2025 12:12
@anutosh491
Copy link
Collaborator Author

Cc @SylvainCorlay this should be ready now !

@SylvainCorlay SylvainCorlay merged commit 2226ca0 into compiler-research:main Jun 6, 2025
56 of 65 checks passed
@anutosh491 anutosh491 deleted the xeus_shared branch June 9, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants