Skip to content

Fix clang tidy #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented May 7, 2024

@vgvassilev This is the PR to correct the bug introduced in clang tidy workflow in the last PR, found in vgvassilev/clad#883 . Once it is has been found to work in Clad this can be merged immediately.

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.39%. Comparing base (bb9bb85) to head (64780d8).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   49.14%   49.39%   +0.24%     
==========================================
  Files          15       15              
  Lines         643      575      -68     
==========================================
- Hits          316      284      -32     
+ Misses        327      291      -36     

see 12 files with indirect coverage changes

see 12 files with indirect coverage changes

@mcbarton mcbarton changed the title Fix install-llvm-action version number so 18.1.3 available Fix clang tidy May 8, 2024
@mcbarton mcbarton marked this pull request as draft May 8, 2024 08:07
@mcbarton
Copy link
Collaborator Author

mcbarton commented May 8, 2024

@maximusron any ideas of how to fix the clang tidy workflow here? The remaining issue which I need to solve is how activate the xeus-cpp envirnoment before the cmake in ZedThree/clang-tidy-review , but any command you will put in the cmake_command will be prepended with a cmake command. I'm running out of ideas of how to have the xeus-cpp envirnoment activated.

Copy link
Contributor

github-actions bot commented May 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton mcbarton marked this pull request as ready for review May 8, 2024 21:22
Copy link
Contributor

github-actions bot commented May 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton
Copy link
Collaborator Author

mcbarton commented May 8, 2024

@vgvassilev @anutosh491 can one of you merge this PR? It fixes the issue of the broken clang tidy introduced by the previous commit. It works around an issue where an action tries to stop you using anything but a cmake command as the first command in the updated action. That's the only way I could find to activate the mamba envirnoment in the updated action. This PR also shows the clang tidy now works.

Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merging !

@anutosh491 anutosh491 merged commit 213c9a6 into compiler-research:main May 9, 2024
7 checks passed
@mcbarton mcbarton deleted the fix-clang-tidy branch May 22, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants