Treat all warnings as errors (non wasm) #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
2 similar comments
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 52.42% 53.66% +1.24%
==========================================
Files 15 15
Lines 599 600 +1
==========================================
+ Hits 314 322 +8
+ Misses 285 278 -7
... and 1 file with indirect coverage changes
|
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
mcbarton
force-pushed
the
treat-warnings-as-errors
branch
from
9bdb911 to
83cce28
Compare
mcbarton
changed the title
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@JohanMabille @vgvassilev can one of you review this PR? |
JohanMabille
requested changes
May 13, 2024
mcbarton
force-pushed
the
treat-warnings-as-errors
branch
from
fe78be1 to
ac8e9d2
Compare
|
@JohanMabille This PR is ready for another review. I have addressed your comments. |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Thanks! |
JohanMabille
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR will change it so when building xeus-cpp it treats all warnings as errors by default. In the ci I turn this off for wasm builds.