Skip to content

Jupyter lite integration #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2024

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented May 15, 2024

The purpose of this PR is debug and hopefully fix the issue in #61.

Fixes #61

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.66%. Comparing base (aa77879) to head (d730578).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage   53.66%   53.66%           
=======================================
  Files          15       15           
  Lines         600      600           
=======================================
  Hits          322      322           
  Misses        278      278           

@mcbarton mcbarton force-pushed the jupyter-lite-debug branch from 41045b1 to 26e9118 Compare May 15, 2024 15:30
@mcbarton mcbarton force-pushed the jupyter-lite-debug branch from d4e9d74 to d730578 Compare May 15, 2024 15:40
@mcbarton
Copy link
Collaborator Author

mcbarton commented May 15, 2024

@vgvassilev This PR to me suggests there is no issue with Jupyter Lite integration. I added to the ci the instructions to build/test a kernel with Jupyter Lite without making a website, and if you look at the ci, it builds without error, picking up the kernels that have been built.

@alexander-penev alexander-penev merged commit 6165b3c into compiler-research:main May 15, 2024
6 checks passed
@davy39
Copy link

davy39 commented May 17, 2024

Thanks for your work. I did try the build getting it in this artifact, but I'm not able to run C++ code with it, not even declaring variables.
Am doing something wrong ?

@mcbarton mcbarton deleted the jupyter-lite-debug branch May 22, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jupyterlite integration
4 participants