annotate overloaded private class members where needed #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Running IDs across the LLVM source, I observed a few cases where private methods that should have been annotated due to being referenced in the same translation unit. In these instances, the missed private methods had overloads and their references were ambiguous. This PR addresses the issue and makes IDS properly flag these methods for export.
Overview
VisitUnresolvedMemberExpr
which gets called in this scenario. Invoke the existingexport_function_if_needed
for each method declaration the expression may reference. This is only done for private methods because public methods will always be annotated.-fno-delayed-template-parsing
, which is already the default on Linux and Darwin. This is required on Windows, where the default behavior is-fdelayed-template-parsing
to better match MSVC behavior. More details here. Without this argument, the new test case does not pass when run on Windows.Validation