Skip to content

Add code to build.ps1 to build the installer (not called yet) #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 10, 2023
Merged

Add code to build.ps1 to build the installer (not called yet) #463

merged 5 commits into from
Mar 10, 2023

Conversation

tristanlabelle
Copy link
Collaborator

No description provided.

Copy link
Owner

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split up the renaming and tweaks into a separate PR so that we can get that merged early?

@tristanlabelle tristanlabelle marked this pull request as ready for review March 10, 2023 17:38
@tristanlabelle tristanlabelle requested a review from compnerd March 10, 2023 17:38
@tristanlabelle tristanlabelle requested a review from compnerd March 10, 2023 17:55
Copy link
Owner

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I still wish that this were three changes, but I'll live :-p.

@compnerd compnerd merged commit 5917dce into compnerd:main Mar 10, 2023
@tristanlabelle tristanlabelle deleted the Build-Installer branch March 10, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants