-
Notifications
You must be signed in to change notification settings - Fork 55
[Mac Build] Add stdlib build #843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e744c95
to
5a2d842
Compare
f5f0bd7
to
cee6e49
Compare
5a2d842
to
6ea346c
Compare
93fad08
to
d65f3fa
Compare
6ea346c
to
fb11672
Compare
34b2bed
to
1d9ced6
Compare
425fe14
to
4643a5a
Compare
4643a5a
to
fe272e4
Compare
fe272e4
to
718402d
Compare
compnerd
reviewed
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance we could re-use or try to upstream the cmake caches?
718402d
to
fb2523c
Compare
22f85d3
to
71128d5
Compare
Steelskin
added a commit
that referenced
this pull request
Jan 30, 2025
In the stdlib job, the toolchain is now extracted under `BinaryCache/Library`, rather then under `BuildRoot/Library`. This allows to change the SDK artifact root path to `BuildRoot/Library`, simplifying download in subsequent jobs and making room for the macOS toolchain paths. Extracted from #843
Steelskin
added a commit
that referenced
this pull request
Jan 31, 2025
Currently, in the `stdlib` job, the toolchain is extracted to `BuildRoot/Library`, and the Swift Standard Library is also installed to `BuildRoot/Library`. Other jobs typically extract the toolchain to `BinaryCache/Library`. This changes the extraction path to `BinaryCache/Library` in the `stdlib` job, bringing it in-line with the rest of the build. In addition, this changes the Swift Standard Library artifact root to be `BuildRoot/Library`, rather than the full path to the platform SDK, `BuildRoot/Library/Developer/Platforms/${{ matrix.os }}.platform`. This is in preparation for adapting the job to build for macOS, where the Swift Standard Library will be installed under `Library/Toolchains/unknown-Asserts-development.xctoolchain/usr`. Extracted from #843
71128d5
to
116e75d
Compare
compnerd
reviewed
Feb 6, 2025
3a56ff0
to
fa28bb6
Compare
compnerd
reviewed
Feb 24, 2025
fa28bb6
to
4b3edb0
Compare
* Adapt stdlib job to build for both Windows and Mac.
4b3edb0
to
eb90037
Compare
compnerd
approved these changes
Feb 25, 2025
The pinned prebuilt does not work with building stdlib on macOS because it is too old.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.