Skip to content

Improved dark mode toggle #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Do you need a separate Vue SPA front-end instead of using Inertia.js? Consider u
- Need SSR support? [There's a branch for that.](https://github.com/connorabbas/laravel-inertia-primevue/tree/feature/ssr)
- Pre-configured [Auto Import](https://primevue.org/autoimport/) PrimeVue components
- Wrapper components for PrimeVue's `Menu`, `MenuBar`, & `PanelMenu` utilizing Inertia's `Link` component
- Light/Dark mode toggle with custom component & composable
- Light/Dark mode toggle
- `useLazyDataTable()` composable for use with PrimeVue's `DataTable` component for easy filtering/sorting (example usage in `feature/admin-panel` branch)
- Easily customizable theming

Expand Down
66 changes: 43 additions & 23 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"vue": "^3.5.0"
},
"dependencies": {
"@vueuse/core": "^12.2.0",
"lodash": "^4.17.21"
}
}
14 changes: 14 additions & 0 deletions resources/js/Components/ToggleDarkModeButton.vue
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<script setup>
import { useDark, useToggle } from '@vueuse/core';

const isDark = useDark();
const toggleDark = useToggle(isDark);
</script>

<template>
<Button
title="Toggle Light/Dark Mode"
:icon="isDark ? 'pi pi-moon' : 'pi pi-sun'"
@click="toggleDark()"
/>
</template>
18 changes: 0 additions & 18 deletions resources/js/Components/ToggleThemeButton.vue

This file was deleted.

22 changes: 0 additions & 22 deletions resources/js/Composables/useTheme.js

This file was deleted.

6 changes: 3 additions & 3 deletions resources/js/Layouts/AuthenticatedLayout.vue
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import Container from '@/Components/Container.vue';
import LinksMenu from '@/Components/PrimeVue/LinksMenu.vue';
import LinksMenuBar from '@/Components/PrimeVue/LinksMenuBar.vue';
import LinksPanelMenu from '@/Components/PrimeVue/LinksPanelMenu.vue';
import ToggleThemeButton from '@/Components/ToggleThemeButton.vue';
import ToggleDarkModeButton from '@/Components/ToggleDarkModeButton.vue';

const currentRoute = route().current();
const logoutForm = useForm({});
Expand Down Expand Up @@ -111,7 +111,7 @@ watchEffect(() => {
class="hidden lg:flex items-center ms-6 space-x-3"
>
<div>
<ToggleThemeButton
<ToggleDarkModeButton
text
severity="secondary"
rounded
Expand Down Expand Up @@ -169,7 +169,7 @@ watchEffect(() => {
<!-- Mobile drawer menu -->
<Drawer v-model:visible="mobileMenuOpen" position="right">
<template #header>
<ToggleThemeButton text severity="secondary" rounded />
<ToggleDarkModeButton text severity="secondary" rounded />
</template>
<div>
<div>
Expand Down
4 changes: 2 additions & 2 deletions resources/js/Pages/Welcome.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script setup>
import ToggleThemeButton from '@/Components/ToggleThemeButton.vue';
import ToggleDarkModeButton from '@/Components/ToggleDarkModeButton.vue';

defineProps({
canLogin: {
Expand Down Expand Up @@ -91,7 +91,7 @@ defineProps({
/>
</Link>
</template>
<ToggleThemeButton outlined />
<ToggleDarkModeButton outlined />
<div class="mt-6">
<p class="m-0 text-sm text-muted-color">
Laravel v{{ laravelVersion }} (PHP v{{
Expand Down
6 changes: 0 additions & 6 deletions resources/js/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import { ZiggyVue } from '../../vendor/tightenco/ziggy';
import PrimeVue from 'primevue/config';
import ToastService from 'primevue/toastservice';

import { useTheme } from '@/Composables/useTheme.js';
import customThemePreset from '@/theme-preset.js';

const appName = import.meta.env.VITE_APP_NAME || 'Laravel';
Expand All @@ -23,11 +22,6 @@ createInertiaApp({
import.meta.glob('./Pages/**/*.vue')
),
setup({ el, App, props, plugin }) {
// set site theme (light/dark mode)
const { initSiteTheme } = useTheme();
initSiteTheme();

// start the app
return createApp({ render: () => h(App, props) })
.use(plugin)
.use(ZiggyVue, Ziggy)
Expand Down
2 changes: 1 addition & 1 deletion resources/js/theme-preset.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const customThemePreset = definePreset(Preset, {
export default {
preset: customThemePreset,
options: {
darkModeSelector: '.dark-mode',
darkModeSelector: '.dark',
cssLayer: {
name: 'primevue',
order: 'tailwind-base, primevue, tailwind-utilities',
Expand Down
2 changes: 1 addition & 1 deletion tailwind.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ module.exports = {
},
},
plugins: [require('postcss-import'), require('tailwindcss-primeui')],
darkMode: ['selector', '[class*="dark-mode"]'],
darkMode: ['selector'],
};