Skip to content

feat(is-ignored): added wildcard ignore for automatic merge commits #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jcarroll2007
Copy link
Contributor

Description

Github deployments have an auto_merge parameter that "attempts to automatically merge the default branch into the requested ref, if it is behind the default branch" .

Motivation and Context

The automatic merge commit generated by a Github Deployment looks like Auto-merge [branch] into [branch] and this was failing commitlint.

How Has This Been Tested?

See this line for the tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Github deployments have an auto_merge parameter that attempts to automatically merge the default branch into the requested ref, if it is behind the default branch . This commit ignores the auto-generated commite message.
@marionebl
Copy link
Contributor

Thanks! Do you have an example of a failing commit in the wild?

@jcarroll2007
Copy link
Contributor Author

@marionebl No problem! Unfortunately, I do not. My failure was in a private repository.

@jcarroll2007
Copy link
Contributor Author

Can we get this merged in?

@marionebl
Copy link
Contributor

Yep, thanks!

@marionebl marionebl merged commit 481d345 into conventional-changelog:master Jun 2, 2018
@jcarroll2007 jcarroll2007 deleted the feat/add-automatic-merge-wildcard branch October 31, 2018 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants