Skip to content

chore: bump glob and related usage #3928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

JounQin
Copy link
Collaborator

@JounQin JounQin commented Feb 22, 2024

After trying, glob can be upgraded safely and easily while cosmiconfig cannot, so I'll hold on upgrading cosmiconfig.

I'll start to add some changesets in this PR at the same time.

I found we're actually managing changelog with lerna + commit message, so there seems nothing left blocking releasing now.

For the following

change to use exports field in package.json (via @marcalexiei)

I'm not for sure to confirm whether it is a must-to-have action because we're using pure ESM now, exports is not required in this case.

@escapedcat escapedcat merged commit 0a583d3 into conventional-changelog:master Feb 22, 2024
@escapedcat
Copy link
Member

❤️ Will create a new release soonish then.

@JounQin JounQin deleted the chore/bump branch February 22, 2024 16:43
@marcalexiei
Copy link
Contributor

marcalexiei commented Feb 22, 2024

I'm not for sure to confirm whether it is a must-to-have action because we're using pure ESM now, exports is not required in this case.

it allows to expose public file to avoid user import from internal files not meant for it.
Most libraries now provide an export key in the package.json.
Adding this feature might result in another breaking change.
I think it's a nice addition but cannot be considered as a blocker so we can move on.

❤️ Will create a new release soonish then.

I can finish the new documentation in the next days so we can release ESM and new doc together

escapedcat pushed a commit that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants