test: refactor test utils to typescript #906
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test utils are currently blocking refactoring of some packages to typescript.
Description
Notes:
@marionebl/sander
package is no longer maintained and there is no type definitions for it, i replaced it withfs-extra
, as node target version is 6 (util.promisify or fs.promises is not supported yet in this version)tmp
package got removed from cli (unused) and is used in test utils as replacement.While refactoring this package i noticed that tmp folders are not removed on windows (we should add call to
removeCallback
) ideally we want that bootstrapping functions returntmp.DirResult
instead of directory.Types of changes
Checklist: