Skip to content

test: refactor test utils to typescript #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 26, 2020

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Jan 26, 2020

Test utils are currently blocking refactoring of some packages to typescript.

Description

Notes:

  • @marionebl/sander package is no longer maintained and there is no type definitions for it, i replaced it with fs-extra, as node target version is 6 (util.promisify or fs.promises is not supported yet in this version)
  • tmp package got removed from cli (unused) and is used in test utils as replacement.

While refactoring this package i noticed that tmp folders are not removed on windows (we should add call to removeCallback) ideally we want that bootstrapping functions return tmp.DirResult instead of directory.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@armano2 armano2 force-pushed the refactor-test-utils branch from 9912ed2 to d678b9a Compare January 26, 2020 18:13
@armano2 armano2 changed the title chore: refactor test utils to typescript test: refactor test utils to typescript Jan 26, 2020
@armano2
Copy link
Contributor Author

armano2 commented Jan 26, 2020

updated

@byCedric byCedric merged commit bc548de into conventional-changelog:master Jan 26, 2020
@armano2 armano2 deleted the refactor-test-utils branch January 26, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants