-
Notifications
You must be signed in to change notification settings - Fork 929
test(cli): migrates tests from ava to jest #907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test('should throw when called without [input]', async t => { | ||
const cwd = await git.bootstrap('fixtures/default'); | ||
const gitBootstrap = fixture => git.bootstrap(fixture, __dirname); | ||
const fixBootstrap = fixture => fix.bootstrap(fixture, __dirname); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is needed as jest is executed from root directory, ava was executed in each package separately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'd figure, I think I briefly discussed this with Mario sometime ago. I'll put it on the list of stuff to do before v9 release 👍
bdw. i do recommend to do squash merges instead (as it will not pollute history with partial commits) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry about the commits, we always squash them down 😄
Looks great, again! ❤️ I can merge it after the |
Migrates CI tests from ava to jest
Description
While doing this refactor i took opportunity to validate why some of tests was not passing on windows machines and i added appropriate comments.
There is still one that is failing on windows machine:
should print full commit message when input from stdin fails
its actually not an issue but test is failing:
How Has This Been Tested?
Unrelated
Types of changes
Checklist: