Skip to content

Fix predictor __init__ staggering #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 24, 2020
Merged

Fix predictor __init__ staggering #1591

merged 3 commits into from
Nov 24, 2020

Conversation

deliahu
Copy link
Member

@deliahu deliahu commented Nov 23, 2020

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@deliahu deliahu requested a review from RobertLucian November 23, 2020 22:44
RobertLucian
RobertLucian approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@RobertLucian RobertLucian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just added a nit.

@deliahu deliahu merged commit 8062a54 into master Nov 24, 2020
@deliahu deliahu deleted the stagger-init branch November 24, 2020 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertLucian RobertLucian RobertLucian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deliahu @RobertLucian