Update bucket settings to be compatible with dp9 and not set defaults for optional fields #121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
BucketSettings
are optional apart fromname
. Don't set default values on them as the core now does not send unset fields to the server. Rely on the core's default value for the RAM quota. Updatecb_generate_bucket_settings
to reflect thesereplica_indexes
andflush_enabled
are now optional booleans in the core. Incb_extract_bucket_settings
use their value to set the corresponding Ruby attributes, as anstd::optional<bool>
is truthy if the value is set (either totrue
orfalse
)nil
if the bucket does not support history retention