Skip to content

Update bucket settings to be compatible with dp9 and not set defaults for optional fields #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

DemetrisChr
Copy link
Contributor

@DemetrisChr DemetrisChr commented Sep 21, 2023

Change

  • All fields in BucketSettings are optional apart from name. Don't set default values on them as the core now does not send unset fields to the server. Rely on the core's default value for the RAM quota. Update cb_generate_bucket_settings to reflect these
  • replica_indexes and flush_enabled are now optional booleans in the core. In cb_extract_bucket_settings use their value to set the corresponding Ruby attributes, as an std::optional<bool> is truthy if the value is set (either to true or false)
  • Update bucket history retention test to expect that bytes/duration default to nil if the bucket does not support history retention

@DemetrisChr DemetrisChr requested a review from avsej September 21, 2023 09:35
@cb-sdk-robot
Copy link
Collaborator

Can one of the admins verify this patch?

@avsej avsej merged commit 15e586b into couchbase:main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants