Skip to content

Ensure that truncating keys in CouchbaseStore preserves the validity of their encoding #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2023
Merged

Ensure that truncating keys in CouchbaseStore preserves the validity of their encoding #125

merged 1 commit into from
Nov 9, 2023

Conversation

DemetrisChr
Copy link
Contributor

  • Instead of using byteslice use limit from active support than ensures that characters are not broken
  • Don't force the encoding to ASCII in normalize_key
  • Add tests to check that truncating keys works as expected

@DemetrisChr DemetrisChr requested a review from avsej November 9, 2023 14:54
@cb-sdk-robot
Copy link
Collaborator

Can one of the admins verify this patch?

@DemetrisChr DemetrisChr merged commit 84481df into couchbase:main Nov 9, 2023
@DemetrisChr DemetrisChr deleted the cache-trunc-key branch November 9, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avsej avsej avsej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DemetrisChr @cb-sdk-robot @avsej