Skip to content

RCBC-482: Only expand MutateIn macros when the relevant symbols are used as values #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2024
Merged

RCBC-482: Only expand MutateIn macros when the relevant symbols are used as values #141

merged 1 commit into from
Apr 5, 2024

Conversation

DemetrisChr
Copy link
Contributor

@DemetrisChr DemetrisChr commented Apr 5, 2024 •
edited
Loading

@expand_macros should only be set to true when the macros are set using the symbols.

From the API documentation:

When symbol specified and it is matches to known macro, it will be expanded

This fixes the insertExpandMacroXattrDoNotFlag failure in FIT.

@DemetrisChr DemetrisChr requested a review from avsej April 5, 2024 15:07
@DemetrisChr DemetrisChr merged commit 59afcf4 into couchbase:main Apr 5, 2024
@DemetrisChr DemetrisChr deleted the RCBC-482-expand-macros branch April 5, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avsej avsej avsej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DemetrisChr @avsej