Skip to content

Replace "this International Standard" with "this document" when #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2017

Conversation

zygoloid
Copy link
Member

@zygoloid zygoloid commented Sep 14, 2017

referring to the document as a body of text.

Cases where that phrasing is used to compare this standard to other
revisions of the C++ standard retain this phrasing for clarity.

Fixes ISO 20 (C++17 DIS)

referring to the document as a body of text.

Cases where that phrasing is used to compare this standard to other
revisions of the C++ standard retain this phrasing for clarity.

Fixes ISO 20 (C++17 DIS)
@@ -3897,7 +3897,7 @@
floating-point types}.
\indextext{floating-point type!implementation-defined}%
\begin{note}
This International Standard imposes no requirements on the accuracy of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this change is a regression, but I can't quite say why. I think it's clear to me that a Standard can make impositions, but it sounds odd that a document would do so.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an improvement, for what it's worth. It clarifies that this document imposes no requirements, but other documents (for instance, other standards that your implementation might follow, such as ISO/IEC 60559, or vendor-specific compiler flags, may impose further requirements). The fact that this document is an International Standard is irrelevant here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that makes sense. It's probably just my lack of familiarity with the phrase, and I'll get used to it. I can see the consistency argument.

``no diagnostic is required'' or which are described as resulting in
``undefined behavior''.

\pnum
\indextext{conformance requirements!method of description}%
Although this International Standard states only requirements on \Cpp
Although this document states only requirements on \Cpp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must admit I find changing some of these places to "this document" a regression. (And I disagree with the ISO directives essentially banning "this International Standard".) I full agree with "this document" when it comes to internal organizations, chapters, etc. Once we get into defining requirements (such as above, or in "imposes no requirements on floating-point"), I feel "this Int. Std." makes it clearer that while it's the job of the Standard to define requirements, it opted not to for this particular case. (And other standards may fill the gap.) Just talking about "this document" seems too low-profile to me.
But ISO says we should use "this document", so my opinion is probably irrelevant.

@zygoloid zygoloid merged commit 9df58d5 into cplusplus:c++17 Sep 14, 2017
@zygoloid zygoloid deleted the iso-20 branch September 14, 2017 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants