Skip to content

[optional.syn] Use decay_t<T> directly instead of "see below" #7247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Sep 4, 2024

The @\seebelow@ has been present since a307ec1, but it's unclear to me why it was preferred. Perhaps it would be an improvement to make the return type clearer in the synopsis.

The `@\seebelow@` has been present since a307ec1, but it's unclear to me why it was used. Perhaps it would be an improvement to make the return type clearer in the synopsis.
@jensmaurer
Copy link
Member

Looks good to me. @jwakely , any concerns?

@jwakely
Copy link
Member

jwakely commented Sep 4, 2024

The see below is present in https://cplusplus.github.io/fundamentals-ts/v1.html

I wonder if at some point it was optional<typename decay<T>::type> and we decided that was too verbose for the synopsis, but then adding decay_t made that unnecessary.

In any case, the change seems good.

@jwakely
Copy link
Member

jwakely commented Sep 4, 2024

Ah yes, in N3793 we had typename decay<T>::type

@jensmaurer jensmaurer merged commit f23059b into cplusplus:main Sep 4, 2024
2 checks passed
@frederick-vs-ja frederick-vs-ja deleted the make_optional-decay_t branch September 4, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants