Skip to content

Remove USR generation workaround for decayed function parameters #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2024
Merged

Remove USR generation workaround for decayed function parameters #595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions src/lib/AST/ASTVisitor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,19 +616,6 @@ class ASTVisitor
if(! (D = FD->getFriendDecl()))
return true;
}
// functions require their parameter types to be decayed
// prior to USR generator to ensure that declarations
// with parameter types which decay to the same type
// generate the same USR
if(const auto* FD = dyn_cast<FunctionDecl>(D))
{
// apply the type adjustments specified in [dcl.fct] p5
// to ensure that the USR of the corresponding function matches
// other declarations of the function that have parameters declared
// with different top-level cv-qualifiers.
for(ParmVarDecl* P : FD->parameters())
P->setType(context_.getSignatureParameterType(P->getType()));
}
return index::generateUSRForDecl(D, usr_);
}

Expand Down
Loading