Deprecate Atomic::Flag
#15805
Draft
Deprecate Atomic::Flag
#15805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API doesn't follow the usual definition of "test and set", and the use cases are fairly limited compared to Atomic(Bool) that is much more useful, for example you control memory ordering.
Comment on lines
461
to
+462
| struct Atomic::Flag | ||
| @[Deprecated("Use Atomic(Bool) instead.")] |
There was a problem hiding this comment.
suggestion: Shouldn't we deprecate the entire type instead of just its constructor?
Suggested change
| struct Atomic::Flag | |
| @[Deprecated("Use Atomic(Bool) instead.")] | |
| @[Deprecated("Use Atomic(Bool) instead.")] | |
| struct Atomic::Flag |
There was a problem hiding this comment.
Yes, but then I don't get any warning, which is odd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example PR that deprecates
Atomic::Flagand replaces its few usages in stdlib.The API doesn't follow the usual definition of "test and set", and the use cases are fairly limited compared to
Atomic(Bool)that is more useful, for example you control memory ordering.Related to #15786