Use ensure_suffix instead of manually checking for suffixes
#15858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method returns `self` if the string ends with the given suffix. Otherwise, returns a new string with the suffix appended.
This method returns `self` if the string starts with the given prefix. Otherwise, returns a new string with the prefix prepended.
straight-shoota
approved these changes
May 30, 2025
| @@ -129,7 +129,7 @@ module Crystal | |||
| def each_file_expansion(filename, relative_to, &) | |||
| relative_filename = "#{relative_to}/#{filename}" | |||
| # Check if .cr file exists. | |||
| yield relative_filename.ends_with?(".cr") ? relative_filename : "#{relative_filename}.cr" | |||
| yield relative_filename.ensure_suffix(".cr") | |||
There was a problem hiding this comment.
Wouldn't this make it so you can't compile the compiler with a previous release?
There was a problem hiding this comment.
I might be misunderstanding it, but I'd expect this PR to be merged after #15782 is merged and released.
There was a problem hiding this comment.
The compiler is always expected to be built with the same version of the standard library, not the stdlib from the host compiler.
So backward compatibility concerns between src/compiler and src don't matter. They always go together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #15782