Add ameba #15875
Draft
Add ameba #15875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds configuration and a CI job for https://github.com/crystal-ameba/ameba
I let ameba generate a config (
ameba --gen-config) but replaced all exclusions with hard disables. Then I fixed the violations for some of the rules, which have already been merged in the last couple of days. So I removed the disables for these rules.The configuration is annotated with explanations in code.
I have disabled most
NamingandStylerules because most had large numbers of violations and some of them seem questionable. We can consider enabling some of the in the future, piece by pieceFor review, it's best to ignore the first three commits and review the rest combined, not the individual commits.
Depends on #15860, #15870
Resolves #14608
Closes #14631