DBA-732 graceful shutdown #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglearns
requested review from
mdashti and
jssmith
and removed request for
mdashti
greglearns
force-pushed
the
DBA-732-shutdown
branch
2 times, most recently
from
9256e22 to
5b9c13b
Compare
jssmith
approved these changes
Apr 8, 2025
src/postgres_mcp/server.py
Outdated
|
|
||
| logger.info("Shutdown complete.") | ||
| os._exit(0) |
There was a problem hiding this comment.
The convention is to exit with code 128 + signal number.
So 130 for SIGINT and 143 for SIGTERM
greglearns
force-pushed
the
DBA-732-shutdown
branch
from
b3ddce3 to
1d1b1fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.