readme updates, including description of sse support #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulcap
reviewed
Apr 17, 2025
README.md
Outdated
| docker run -p 8000:8000 -e DATABASE_URI=postgresql://username:password@localhost:5432/dbname crystaldba/postgres-mcp --transport sse | ||
| docker run -p 8000:8000 \ | ||
| -e DATABASE_URI=postgresql://username:password@localhost:5432/dbname \ | ||
| crystaldba/postgres-mcp --transport=sse |
There was a problem hiding this comment.
up to you as this is a minor comment -- but I think it'd be nice to include the access-mode param here only because we default to "unrestricted" which may be unexpected.
rahulcap
reviewed
Apr 17, 2025
| @@ -272,14 +278,26 @@ For example, in Windsurf's `mcp_config.json` you can put: | |||
| } | |||
| ``` | |||
There was a problem hiding this comment.
The "In Widsurf" was hard to notice as it was in the previous line. Can make it more clear like maybe put "In Winsurf" in e new line and maybe bold windsurf? Or make a list?
Also -- I suggest we put the Cursor/CLine config first as that config with url seems more common
rahulcap
requested changes
Apr 17, 2025
There was a problem hiding this comment.
Overall looks good. Left two comments.
- including "access-level" in docker cmd -- I could go either way on this but a slight pref to highlighting the feature in the command
- making the config for cursor/cline/windsurf more clear. I'd like to see the cursor/cline one first, and break out the line htat starts with "In Windsurf" so its more clear its for that ide
rahulcap
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.