Skip to content

fix so that the wrapper-opening does not gets duplicated #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2016

Conversation

dennisvandehoef
Copy link
Contributor

Hi,

I have found a bug where (wenn generating with an wrapper-open and wrapper-close) the wrapper-open text stays in the document.

The wrapper-open content gets repeated even more when renewing the annotations.

transforming:

# rubocop:disable Metrics/LineLength
# == Schema Information
#
# Table name: pages
#
# *id*::                            <tt>integer, not null, primary key</tt>
# *created_at*::                    <tt>datetime</tt>
# *updated_at*::                    <tt>datetime</tt>
#--
# == Schema Information End
#++
# rubocop:enable Metrics/LineLength

into:

# rubocop:disable Metrics/LineLength
# == Schema Information
#
# Table name: pages
#
# *id*::                            <tt>integer, not null, primary key</tt>
# *created_at*::                    <tt>datetime</tt>
# *updated_at*::                    <tt>datetime</tt>
#--
# == Schema Information End
#++
# rubocop:enable Metrics/LineLength

# rubocop:disable Metrics/LineLength

in this example the # rubocop:disable Metrics/LineLength gets increased on every annotation change.

this pull request fixes this bug.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 73.065% when pulling e30044e on dennisvandehoef:remove_wrapper_content into 5dde3cc on ctran:develop.

@ctran ctran added the bug label Apr 13, 2016
@ctran ctran added this to the v2.7.1 milestone Apr 13, 2016
@ctran ctran merged commit f1fa351 into ctran:develop Apr 13, 2016
@ctran
Copy link
Owner

ctran commented Apr 13, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants