-
Notifications
You must be signed in to change notification settings - Fork 657
Provide :hide_default_column_types option to make hiding of default configurable #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changes Unknown when pulling bd910b0 on jastkand:configurable-hiding-of-default into * on ctran:develop*. |
Great! One question though, I didn't see the existing defaults of "json,jsonb,hstore" being used if the option is not specified. Did I miss it somewhere? |
The goal was to be able to disable hiding of Now I've updated the code to have the same behavior as |
Changes Unknown when pulling dbf19d7 on jastkand:configurable-hiding-of-default into * on ctran:develop*. |
…ypes` option is not provided
Changes Unknown when pulling e007765 on jastkand:configurable-hiding-of-default into * on ctran:develop*. |
@ctran Would you mind taking a look at the PR? |
Thanks!!! |
I'm trying to use this in our environment, but doesn't seem to be working. I have |
@nneal do you use version of gem from master? The feature is not yes released in rubygems version of gem. |
I am using |
…onfigurable (ctran#389) * Provide :hide_default_column_types option to make hiding of default configurable * Use `NO_DEFAULT_COL_TYPES` as default when the `hide_default_column_types` option is not provided
First of all, thanks for the great gem!
2.7.0
release made hidden the default value ofhstore
,json
andjsonb
columns. It's reasonable in such cases like this: #320. But that's not good when the default value is more simple, likedefault({})
ordefault([])
. I think it would be great to have hiding ofdefault
configurable. This pull-request introduces this feature.