Skip to content

Fixed Posgresql index tables with public. #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2016

Conversation

ryanfox1985
Copy link
Contributor

@ryanfox1985 ryanfox1985 commented Oct 7, 2016

Hello,

I have a issue with my Postgresql database and the index annotations.
In some models I added the table_name_prefix = 'public.' because I'm using different schemas and the annotation doesn't work because is looking for 'public.table_name' and doesn't exist.

Regards.

@coveralls
Copy link

coveralls commented Oct 7, 2016

Coverage Status

Changes Unknown when pulling 62004f8 on ryanfox1985:postgresql-issue into * on ctran:develop*.

@coveralls
Copy link

coveralls commented Oct 7, 2016

Coverage Status

Changes Unknown when pulling d71abbd on ryanfox1985:postgresql-issue into * on ctran:develop*.

@coveralls
Copy link

coveralls commented Oct 7, 2016

Coverage Status

Changes Unknown when pulling 6ce3c96 on ryanfox1985:postgresql-issue into * on ctran:develop*.

@ctran
Copy link
Owner

ctran commented Oct 24, 2016

I would like to see a test case added for this if you don't mind.

@ctran ctran added the reviewed label Oct 24, 2016
@ryanfox1985
Copy link
Contributor Author

Hi @ctran,

I will describe my case:

We are using Postgresql that supports to have multiples schemas (like public and data_warehouse).
Both schemas are sync (in structure) but we have some models using the table_name_prefix pointing to the public schema (like Users) because the data were the same.

Let me add Rspec test to this part.

Regards.

@ctran
Copy link
Owner

ctran commented Dec 13, 2016

@ryanfox1985 Did you have a chance to add a test?

@ryanfox1985
Copy link
Contributor Author

@ctran It's not easy to make a test xD.
It will be the first that test the indexes.

@coveralls
Copy link

coveralls commented Dec 13, 2016

Coverage Status

Coverage decreased (-0.05%) to 20.976% when pulling e40c243 on ryanfox1985:postgresql-issue into 417d10b on ctran:develop.

Added indexes test.

Added test not crash getting indexes.
@coveralls
Copy link

coveralls commented Dec 13, 2016

Coverage Status

Coverage increased (+1.7%) to 76.148% when pulling e7b01bd on ryanfox1985:postgresql-issue into 1a13713 on ctran:develop.

@coveralls
Copy link

coveralls commented Dec 13, 2016

Coverage Status

Coverage increased (+1.7%) to 76.148% when pulling f434821 on ryanfox1985:postgresql-issue into 1a13713 on ctran:develop.

@coveralls
Copy link

coveralls commented Dec 13, 2016

Coverage Status

Coverage increased (+1.7%) to 76.148% when pulling ec4f313 on ryanfox1985:postgresql-issue into 1a13713 on ctran:develop.

@ryanfox1985
Copy link
Contributor Author

@ctran it's ready.

@ctran ctran merged commit cce4bb1 into ctran:develop Dec 13, 2016
@ctran ctran added this to the v2.7.2 milestone Dec 17, 2016
@ctran ctran added the feature label Dec 17, 2016
johncarney pushed a commit to johncarney/annotate_models that referenced this pull request Jun 19, 2017
* Fixed Posgresql index tables with `public`.

Added indexes test.

Added test not crash getting indexes.

* Updated rake and rubocop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants