Skip to content

Do not include auto-generated foreign key names in schema dump #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2016
Merged

Do not include auto-generated foreign key names in schema dump #408

merged 2 commits into from
Oct 24, 2016

Conversation

vergenzt
Copy link
Contributor

Closes #404.

@coveralls
Copy link

coveralls commented Oct 16, 2016 •
edited
Loading

Coverage Status

Changes Unknown when pulling a3ade5d on vergenzt:skip-autogened-foreign-key-names into * on ctran:develop*.

@vergenzt
Copy link
Contributor Author

Hi @ctran: The tests and coverage check appear to pass, but semaphoreci and the Travis build are failing and I'm not sure why.

Any ideas?

@vergenzt vergenzt mentioned this pull request Oct 17, 2016
Closed
@ctran ctran added the feature label Oct 17, 2016
@ctran ctran added this to the v2.7.2 milestone Oct 17, 2016
@ctran ctran self-assigned this Oct 17, 2016
@ctran
Copy link
Owner

ctran commented Oct 17, 2016 •
edited
Loading

@vergenzt Thanks for this. I'll take a look to see why it failed the CI.

@vergenzt
Copy link
Contributor Author

Thanks. I looked into it and it looked like all the errors in both systems came down to a dependency installation error: ruby_dep-1.5.0 requires ruby version >= 2.2.5, which is incompatible with the current version, ruby 2.2.3p173. However I didn't change any dependencies. :(

@ctran
Copy link
Owner

ctran commented Oct 17, 2016

It's probably something that wasn't locked in the Gemfile :(

@ctran ctran merged commit 270e1c2 into ctran:develop Oct 24, 2016
johncarney pushed a commit to johncarney/annotate_models that referenced this pull request Jun 19, 2017
@vergenzt @johncarney
Do not include auto-generated foreign key names in schema dump (ctran…
7c37404 
…#408)

* add(annotate_models_spec): test coverage
* change(annotate_models#get_foreign_key_info): elide auto-generated fk names

Closes ctran#404.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ctran ctran

Labels
feature
Projects
None yet
Milestone
v2.7.2
Development

Successfully merging this pull request may close these issues.
3 participants
@vergenzt @coveralls @ctran