Valid for rake earlier than v 12.1 #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
b264
reviewed
Dec 12, 2016
| @@ -26,10 +26,10 @@ Gem::Specification.new do |s| | |||
| s.specification_version = 4 | |||
|
|
|||
| if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then | |||
| s.add_runtime_dependency(%q<rake>, [">= 10.4", "< 12.0"]) | |||
| s.add_runtime_dependency(%q<rake>, [">= 10.4", "< 12.1"]) | |||
There was a problem hiding this comment.
Just curious, why not "< 13.0" ?
There was a problem hiding this comment.
12 -> 13 should break a ton of stuff if they're using semantic versioning. I tested it with 12, but I can't be sure 13 will work out of the box until I get my hands on that version and can test.
There was a problem hiding this comment.
I mean less than 13 like "< 13" but this merged already anyway 👍
ctran
approved these changes
Dec 13, 2016
| @@ -26,10 +26,10 @@ Gem::Specification.new do |s| | |||
| s.specification_version = 4 | |||
|
|
|||
| if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then | |||
| s.add_runtime_dependency(%q<rake>, [">= 10.4", "< 12.0"]) | |||
| s.add_runtime_dependency(%q<rake>, [">= 10.4", "< 12.1"]) | |||
johncarney
pushed a commit
to johncarney/annotate_models
that referenced
this pull request
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Rake is v 12.0.0 and Gem won't install