Skip to content

Added new gems. #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 13, 2016
Merged

Added new gems. #419

merged 3 commits into from
Dec 13, 2016

Conversation

ryanfox1985
Copy link
Contributor

@ryanfox1985 ryanfox1985 commented Dec 13, 2016

Added byebug for debugging.

@coveralls
Copy link

coveralls commented Dec 13, 2016

Coverage Status

Coverage remained the same at 21.024% when pulling f4bcb8f on ryanfox1985:added_gems into 417d10b on ctran:develop.

@ctran
Copy link
Owner

ctran commented Dec 13, 2016

Could you explain why we need this?

@ryanfox1985
Copy link
Contributor Author

Hi @ctran,

the gem byebug is works very well to debug the gem. Putting byebug in the code you are creating a breakpoint and you have a shell (better than puts xD).

Let me fix the tests before merge.

Regards.

@ryanfox1985
Copy link
Contributor Author

ryanfox1985 commented Dec 13, 2016

@ctran the merge is baddddd (you need to rebase from develop), don't worry I will rebase and fix it.

@coveralls
Copy link

coveralls commented Dec 13, 2016

Coverage Status

Coverage remained the same at 76.148% when pulling d7cb38b on ryanfox1985:added_gems into cce4bb1 on ctran:develop.

@ryanfox1985
Copy link
Contributor Author

@ctran can you add this:

bundle exec rubocop && bundle exec rspec

to the semaphoreCI?

@ryanfox1985
Copy link
Contributor Author

@ctran ready to merge.

@coveralls
Copy link

coveralls commented Dec 13, 2016

Coverage Status

Coverage increased (+0.4%) to 76.505% when pulling 8173e8f on ryanfox1985:added_gems into cce4bb1 on ctran:develop.

@ctran ctran merged commit e2b250b into ctran:develop Dec 13, 2016
@ctran ctran added the refactor label Dec 17, 2016
johncarney pushed a commit to johncarney/annotate_models that referenced this pull request Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants