Support :change migrations in Rails 3.1 #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like this would break for older version of Rails? |
|
Hmm. I guess I don't understand that call then. I thought it was catching migrations of those types and would ignore them if they didn't happen. I'd test it, but I can't actually get the annotation to happen on migration at all. The README is explicitly vague on how to accomplish this. Is it working for others? |
|
Now that I have time to read the change again, I think this may not break previous versions. |
|
Nope. Maybe because I'm on Rails 3.1rc5? I don't see anything in the logs either. I don't mind using the |
turadg
added a commit
that referenced
this pull request
Sep 2, 2011
Support :change migrations in Rails 3.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 3.1 adds :change as a way to specify a migration. Add it to the Annotate rake task so it picks those up.