Skip to content

Moved rubocop to outside. #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2016
Merged

Moved rubocop to outside. #420

merged 1 commit into from
Dec 13, 2016

Conversation

ryanfox1985
Copy link
Contributor

Hi,

I moved Rubocop to the CI, it's better not runs Rubocop in the tests.
The best will be run in two pipelines.

Regards.

@coveralls
Copy link

coveralls commented Dec 13, 2016 •
edited
Loading

Coverage Status

Coverage increased (+53.4%) to 74.401% when pulling aa6acdb on ryanfox1985:fix_rubocop into 417d10b on ctran:develop.

@ctran ctran merged commit 1a13713 into ctran:develop Dec 13, 2016
@ctran
Copy link
Owner

ctran commented Dec 13, 2016

Thanks!!!

@ctran ctran added the refactor label Dec 17, 2016
johncarney pushed a commit to johncarney/annotate_models that referenced this pull request Jun 19, 2017
@ryanfox1985 @johncarney
Moved rubocop to outside. (ctran#420)
c354e35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanfox1985 @coveralls @ctran