Fix README #494
Merged
Fix README #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b264
reviewed
Jul 26, 2017
|
|
||
| Into Gemfile from Github: | ||
|
|
||
| gem 'annotate', git: 'https://github.com/ctran/annotate_models.git' | ||
| gem 'annotate', github: 'ctran/annotate_models', require: false |
There was a problem hiding this comment.
This will cause an non-secure warning, right?
There was a problem hiding this comment.
This block is which was declared on the top of Gemfile:
git_source(:github) {|repo_name| "https://github.com/#{repo_name}.git" }Its a workaround for a bug in Bundler which can cause sources from github to loaded via HTTP and not HTTPS - which makes it vulnerable to man in the middle attacks. We'll usually not remove it.
There was a problem hiding this comment.
Thanks for pointing this out to me. The short form doesn't seem to gain us much and has a security downside. I would rather use the longer form in this case.
There was a problem hiding this comment.
Oh, I see. I'll fix it, soon.
There was a problem hiding this comment.
@yhirano55 don't worry about it, I already started #496.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added option
require: falseon Usage. Because this gem doesn't need autorequiring. And I've refactored tiny things. Thanks.