Skip to content

annotate bigint correctly #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2017
Merged

annotate bigint correctly #515

merged 1 commit into from
Oct 11, 2017

Conversation

willnet
Copy link
Contributor

@willnet willnet commented Oct 11, 2017

Bigint columns display integer in annotation. Because ActiveRecord::ConnectionAdapters::Column#type returns :integer if its column type is bigint.

#bigint? is provided to distinguish them so I changed to use it.

@ctran ctran added this to the v2.7.3 milestone Oct 11, 2017
@ctran ctran added the feature label Oct 11, 2017
@ctran ctran merged commit 63cc88c into ctran:develop Oct 11, 2017
@ctran
Copy link
Owner

ctran commented Oct 11, 2017

Thanks!

@willnet willnet deleted the bigint branch October 11, 2017 04:10
@ykzts ykzts mentioned this pull request Nov 15, 2017
Merged
@siegfault siegfault mentioned this pull request Jul 30, 2018
Merged
@gravitystorm gravitystorm mentioned this pull request May 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
v2.7.3
Development

Successfully merging this pull request may close these issues.
2 participants
@willnet @ctran