Skip to content

[Fix #281, #413]: Try to get proper loaded model when using Rails eager_load_paths #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Dec 4, 2017
Merged

[Fix #281, #413]: Try to get proper loaded model when using Rails eager_load_paths #535

merged 1 commit into from Dec 4, 2017

Conversation

ghost
Copy link

@ghost ghost commented Dec 1, 2017

No description provided.

@ghost ghost changed the title Try to get proper loaded model when using Rails eager_load_paths, Fix #281, #413 [Fix #281, #413]: Try to get proper loaded model when using Rails eager_load_paths Dec 1, 2017
@ctran
Copy link
Owner

ctran commented Dec 1, 2017 •
edited
Loading

Could you add the spec mentioned in #533 so we can see that it did fix the problem?

@ghost
Copy link
Author

ghost commented Dec 2, 2017 •
edited by ghost
Loading

@ctran added a test case

ps: the integration test is temporarily ignored in Travis, and i cannot make it work on my personal notebook too
pps: I use a repo based on #281 to test it

@ctran ctran added this to the v2.7.3 milestone Dec 4, 2017
@ctran ctran assigned ghost Dec 4, 2017
@ctran ctran merged commit e3e0bbe into ctran:develop Dec 4, 2017
@ctran ctran added the bug label Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.7.3
Development

Successfully merging this pull request may close these issues.
1 participant
@ctran