Refactor and simplify returns #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After you get 573 merged, I'll rebase this one too and hopefully that will make the diff simpler. |
CyborgMaster
force-pushed
the
refactor-returns
branch
from
08dae7c to
4ab211e
Compare
|
Rebased! If you hide the whitespace changes now, the diff is quite short. |
|
Thanks!!! |
|
You're welcome. Thanks for getting these merged so fast. I don't think I've seen such a quick turn around on an OSS project before. Much appreciated. |
mgpnd
pushed a commit
to mgpnd/annotate_models
that referenced
this pull request
Feb 15, 2019
* refactor and simplify returns for annotate_one_file * fix rubocop offenses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and simplify returns for
annotate_one_file. This simplifies some big if/else blocks that were wrapping significant portions of this method. No logic is changed.This is best viewed hiding whitespace changes (under the "Diff settings" button).
This is currently built on top of #573, because it hits the same lines of code (I split it out because the whitespace changes make it hit every line in the function). If for some reason you want to merge this one and not #573, I'll be happy to refactor.