Fix alignment of multi-byte fullwidth character comments #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oieioi
force-pushed
the
feature/multibyte-comment
branch
2 times, most recently
from
5b0a312 to
c1f9d8a
Compare
This fixes alignment of Japanese, Korean and Chinese fullwidth character comments. The displayed widths of multi-byte fullwidth characters are generally twice as large as the ASCII characters, but String#size returns only the number of characters. So if the column comment contains fullwidth multibyte characters, the alignment is broken.
oieioi
force-pushed
the
feature/multibyte-comment
branch
from
c1f9d8a to
ccc6590
Compare
|
Thanks! |
mgpnd
pushed a commit
to mgpnd/annotate_models
that referenced
this pull request
Feb 15, 2019
This fixes alignment of Japanese, Korean and Chinese fullwidth character comments. The displayed widths of multi-byte fullwidth characters are generally twice as large as the ASCII characters, but String#size returns only the number of characters. So if the column comment contains fullwidth multibyte characters, the alignment is broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes alignment of Japanese, Korean and Chinese fullwidth character comments.
The displayed widths of multi-byte fullwidth characters are generally
twice as large as the ASCII characters, but String#size returns only the number of characters.
So if the column comment contains fullwidth multibyte characters, the alignment is broken.
Monospaced font-family supporting multi-byte isn't used in GitHub diff view, you can confirm the fixed alignment with
font-family: "Osaka-mono", "MS Gothic";.cf. https://gyazo.com/d878a077b7494f07bcc45ecf7c0adb62