Do not add whitespace after magic comments when annotating at position after/bottom #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks!!! |
|
Whitespace is still added when there is a module wrapping the class |
mgpnd
pushed a commit
to mgpnd/annotate_models
that referenced
this pull request
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When position is set to after or bottom the current behavior added an extra newline following magic comments.
If the file is being annotated at position after/bottom there should be no need to make modifications after the magic comments. (Any style/formatting there is not the concern of this gem if the file is not being annotated there.)
This change fixes that behavior to only insert a newline if the file is being annotated at position before/top, i.e. between the magic comments and existing content.