Refactor Parser #641
Merged
Refactor Parser #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored Parser to isolate changes being made to ENV. This way we have an intermediate step where we know the environment variables being set.
drwl
force-pushed
the
drwl/refactor-parser2
branch
from
d418bac to
230b809
Compare
|
One step forward! |
ryanwjackson
pushed a commit
to ryanwjackson/annotate_models
that referenced
this pull request
Aug 6, 2019
Refactored Parser to isolate changes being made to ENV. This way we have an intermediate step where we know the environment variables being set.
peterfication
pushed a commit
to store2be/annotate_models
that referenced
this pull request
Jan 20, 2020
Refactored Parser to isolate changes being made to ENV. This way we have an intermediate step where we know the environment variables being set.
vfonic
pushed a commit
to vfonic/annotate_models
that referenced
this pull request
May 8, 2020
Refactored Parser to isolate changes being made to ENV. This way we have an intermediate step where we know the environment variables being set.
|
Still having a look at the codebase here for the first time, but it looks like line 59 of this commit may be causing issue #802 annotate_models/lib/annotate/parser.rb Lines 56 to 60 in 407ace6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored Parser to isolate changes being made to ENV. This way we have an intermediate step where we know the environment variables being set.