Fix foreign key issue with Rails 6 and Sqlite3 #695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 6 has dropped name from ActiveRecord::ConnectionAdapters::ForeignKeyDefinition for Sqlite3 adapter: https://github.com/rails/rails/blob/f2df77709f7e536aaf4d6f984ff21a49d44d34c1/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb\#L305-L311 This has caused issues with getting foreign key info and blowing up when trying to annotate models with foreign keys. This commit adds one additional check for name presence and uses column attribute from options instead. Closes ctran#620.
|
@shime thanks for the patch. It looks good to me. Just for my understanding, can you elaborate more on the code you linked to? v5.2 looks to have the same code |
peterfication
pushed a commit
to store2be/annotate_models
that referenced
this pull request
Jan 20, 2020
Rails 6 has dropped name from ActiveRecord::ConnectionAdapters::ForeignKeyDefinition for Sqlite3 adapter: https://github.com/rails/rails/blob/f2df77709f7e536aaf4d6f984ff21a49d44d34c1/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb\#L305-L311 This has caused issues with getting foreign key info and blowing up when trying to annotate models with foreign keys. This commit adds one additional check for name presence and uses column attribute from options instead. Closes ctran#620.
vfonic
pushed a commit
to vfonic/annotate_models
that referenced
this pull request
May 8, 2020
Rails 6 has dropped name from ActiveRecord::ConnectionAdapters::ForeignKeyDefinition for Sqlite3 adapter: https://github.com/rails/rails/blob/f2df77709f7e536aaf4d6f984ff21a49d44d34c1/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb\#L305-L311 This has caused issues with getting foreign key info and blowing up when trying to annotate models with foreign keys. This commit adds one additional check for name presence and uses column attribute from options instead. Closes ctran#620.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 6 has dropped name from options for ActiveRecord::ConnectionAdapters::ForeignKeyDefinition
for Sqlite3 adapter:
https://github.com/rails/rails/blob/f2df77709f7e536aaf4d6f984ff21a49d44d34c1/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L305-L311
This has caused issues with getting foreign key info and blowing up
when trying to annotate models with foreign keys. This commit
adds one additional check for name presence and uses column
attribute from options instead.
Closes #620.