Skip to content

Fix additional_file_patterns parsing #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2020
Merged

Fix additional_file_patterns parsing #756

merged 1 commit into from
Feb 13, 2020

Conversation

ryanwjackson
Copy link
Contributor

There is a bug where additional_file_patterns are not parsed as an array from the rake config. This splits them by ,, as the parser.rb for CLI args.

@ryanwjackson ryanwjackson requested a review from drwl February 11, 2020 00:46
drwl
drwl approved these changes Feb 13, 2020
View reviewed changes
Copy link
Collaborator

@drwl drwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch 🙌

@drwl drwl merged commit 5176bb8 into ctran:develop Feb 13, 2020
vfonic pushed a commit to vfonic/annotate_models that referenced this pull request May 8, 2020
@ryanwjackson @vfonic
Fix additional_file_patterns parsing (ctran#756)
9ff3405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwl drwl drwl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanwjackson @drwl