Skip to content

Move some codes from AnnotateModels to AnnotateModels::SchemaInfo #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 33 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
011d01c
Move helpers in annotate_models_spec.rb
nard-tech Jan 15, 2020
f4da457
Clean spec_helper.rb
nard-tech Feb 8, 2020
daf4b0d
Execute `rubocop --auto-gen-config`
nard-tech Feb 8, 2020
1722e61
Execute `rubocop -a --only Layout/SpaceInsideBlockBraces`
nard-tech Feb 9, 2020
a358af8
Execute `rubocop -a --only Style/TrailingCommaInArrayLiteral`
nard-tech Feb 9, 2020
700a9f9
Execute `rubocop -a --only Style/FormatString`
nard-tech Feb 9, 2020
6c35ddf
Execute `rubocop -a --only Layout/SpaceBeforeBlockBraces`
nard-tech Feb 9, 2020
e37a857
Execute `rubocop -a --only Layout/SpaceAroundOperators`
nard-tech Feb 9, 2020
8ad5f82
Execute `rubocop -a --only Layout/SpaceBeforeComment`
nard-tech Feb 9, 2020
f629eb9
Execute `rubocop -a --only Style/StringLiterals`
nard-tech Feb 9, 2020
0915502
Execute `rubocop -a --only Style/PercentLiteralDelimiters`
nard-tech Feb 9, 2020
8a6b9ae
Execute `rubocop -a --only Layout/AlignArguments`
nard-tech Feb 9, 2020
1a97f55
Execute `rubocop -a --only Layout/SpaceInsideParens`
nard-tech Feb 9, 2020
dafa682
Execute `rubocop -a --only Layout/SpaceInsideStringInterpolation`
nard-tech Feb 9, 2020
9345d24
Execute `rubocop -a --only Style/StringLiteralsInInterpolation`
nard-tech Feb 9, 2020
6ed7231
Execute `rubocop -a --only Style/RedundantParentheses`
nard-tech Feb 9, 2020
f0b8bd9
Execute `rubocop -a --only Style/IfUnlessModifier`
nard-tech Feb 9, 2020
1455971
Execute `rubocop -a --only Layout/MultilineOperationIndentation`
nard-tech Feb 9, 2020
a96a3b0
Execute `rubocop -a --only Layout/EmptyLineAfterGuardClause`
nard-tech Feb 9, 2020
705c836
Execute `rubocop -a --only Layout/ExtraSpacing`
nard-tech Feb 10, 2020
28c29fd
Fix Rubocop Style/NumericPredicate violation
nard-tech Feb 10, 2020
42dd1a5
Fix Rubocop Lint/AssignmentInCondition violation
nard-tech Feb 10, 2020
be8c3d9
Refactor AnnotateModels::SchemaInfo.generate
nard-tech Feb 9, 2020
c3dfca5
Execute `rubocop --auto-gen-config`
nard-tech Feb 10, 2020
083bb0d
Clean style of AnnotateModels::SchemaInfo
nard-tech Jan 15, 2020
e26bcfa
Remove comment for rubocop:disable in AnnotateModels
nard-tech Feb 10, 2020
9def568
Add comments for rubocop:disable
nard-tech Feb 10, 2020
eab6b0a
Execute `rubocop --auto-gen-config`
nard-tech Feb 10, 2020
cf77430
Refactor AnnotateModels::SchemaInfo.with_comments?
nard-tech Feb 13, 2020
aea68f2
Remove safe navigation operator (&) for Ruby 2.2
nard-tech Feb 26, 2020
6e5af1a
Execute `rubocop --auto-gen-config`
nard-tech Feb 26, 2020
4edcb79
Remove unnecessary comment for disabling Rubocop
nard-tech Apr 7, 2020
5e1fe82
Sort methods in order of appearance
nard-tech Apr 7, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
127 changes: 25 additions & 102 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2020-04-06 10:26:11 +0900 using RuboCop version 0.68.1.
# on 2020-04-07 16:25:20 +0900 using RuboCop version 0.68.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand All @@ -21,7 +21,7 @@ Gemspec/RequiredRubyVersion:
Exclude:
- 'annotate.gemspec'

# Offense count: 65
# Offense count: 62
# Cop supports --auto-correct.
# Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
# SupportedHashRocketStyles: key, separator, table
Expand All @@ -30,7 +30,7 @@ Gemspec/RequiredRubyVersion:
Layout/AlignHash:
Exclude:
- 'lib/generators/annotate/templates/auto_annotate_models.rake'
- 'spec/lib/annotate/annotate_models_spec.rb'
- 'spec/spec_helper.rb'

# Offense count: 1
# Cop supports --auto-correct.
Expand All @@ -40,7 +40,7 @@ Layout/BlockAlignment:
Exclude:
- 'lib/annotate/annotate_models.rb'

# Offense count: 9
# Offense count: 7
# Cop supports --auto-correct.
Layout/EmptyLineAfterGuardClause:
Exclude:
Expand All @@ -55,13 +55,12 @@ Layout/EmptyLineAfterMagicComment:
- 'annotate.gemspec'
- 'spec/lib/annotate/annotate_models_spec.rb'

# Offense count: 3
# Offense count: 2
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
Layout/ExtraSpacing:
Exclude:
- 'Guardfile'
- 'lib/annotate/annotate_models.rb'
- 'lib/tasks/annotate_routes.rake'

# Offense count: 16
Expand All @@ -71,7 +70,7 @@ Layout/ExtraSpacing:
Layout/IndentFirstArrayElement:
EnforcedStyle: consistent

# Offense count: 5
# Offense count: 4
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, IndentationWidth.
# SupportedStyles: aligned, indented
Expand All @@ -87,38 +86,13 @@ Layout/SpaceAroundEqualsInParameterDefault:
Exclude:
- 'lib/annotate/annotate_routes.rb'

# Offense count: 4
# Offense count: 2
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment.
Layout/SpaceAroundOperators:
Exclude:
- 'lib/annotate/annotate_models.rb'
- 'lib/tasks/annotate_routes.rake'

# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
# SupportedStyles: space, no_space
# SupportedStylesForEmptyBraces: space, no_space
Layout/SpaceBeforeBlockBraces:
Exclude:
- 'lib/annotate/annotate_models.rb'

# Offense count: 1
# Cop supports --auto-correct.
Layout/SpaceBeforeComment:
Exclude:
- 'lib/annotate/annotate_models.rb'

# Offense count: 4
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
# SupportedStyles: space, no_space
# SupportedStylesForEmptyBraces: space, no_space
Layout/SpaceInsideBlockBraces:
Exclude:
- 'lib/annotate/annotate_models.rb'

# Offense count: 4
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
Expand All @@ -128,35 +102,13 @@ Layout/SpaceInsideHashLiteralBraces:
Exclude:
- 'lib/tasks/annotate_models.rake'

# Offense count: 4
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: space, no_space
Layout/SpaceInsideParens:
Exclude:
- 'lib/annotate/annotate_models.rb'

# Offense count: 2
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: space, no_space
Layout/SpaceInsideStringInterpolation:
Exclude:
- 'lib/annotate/annotate_models.rb'

# Offense count: 2
# Cop supports --auto-correct.
# Configuration parameters: AllowInHeredoc.
Layout/TrailingWhitespace:
Exclude:
- 'spec/lib/annotate/annotate_routes_spec.rb'

# Offense count: 2
# Configuration parameters: AllowSafeAssignment.
Lint/AssignmentInCondition:
Exclude:
- 'lib/annotate/annotate_models.rb'

# Offense count: 1
Lint/HandleExceptions:
Exclude:
Expand All @@ -170,12 +122,6 @@ Lint/InheritException:
Exclude:
- 'lib/annotate/annotate_models.rb'

# Offense count: 1
# Configuration parameters: MaximumRangeSize.
Lint/MissingCopEnableDirective:
Exclude:
- 'lib/annotate/annotate_models.rb'

# Offense count: 2
Lint/RescueException:
Exclude:
Expand Down Expand Up @@ -208,7 +154,12 @@ Metrics/CyclomaticComplexity:
# Offense count: 30
# Configuration parameters: CountComments, ExcludedMethods.
Metrics/MethodLength:
Max: 40
Max: 33

# Offense count: 1
# Configuration parameters: CountComments.
Metrics/ModuleLength:
Max: 303

# Offense count: 9
Metrics/PerceivedComplexity:
Expand All @@ -224,6 +175,7 @@ Naming/AccessorMethodName:
# Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
Naming/HeredocDelimiterNaming:
Exclude:
- 'spec/lib/annotate/annotate_models/schema_info_spec.rb'
- 'spec/lib/annotate/annotate_models_spec.rb'
- 'spec/lib/annotate/annotate_routes_spec.rb'

Expand Down Expand Up @@ -273,14 +225,15 @@ Style/Dir:
Exclude:
- 'bin/annotate'

# Offense count: 10
# Offense count: 11
Style/Documentation:
Exclude:
- 'spec/**/*'
- 'test/**/*'
- 'lib/annotate.rb'
- 'lib/annotate/active_record_patch.rb'
- 'lib/annotate/annotate_models.rb'
- 'lib/annotate/annotate_models/schema_info.rb'
- 'lib/annotate/annotate_routes.rb'
- 'lib/annotate/annotate_routes/header_generator.rb'
- 'lib/annotate/annotate_routes/helpers.rb'
Expand All @@ -301,22 +254,14 @@ Style/ExpandPathArguments:
Exclude:
- 'annotate.gemspec'

# Offense count: 9
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: format, sprintf, percent
Style/FormatString:
Exclude:
- 'lib/annotate/annotate_models.rb'

# Offense count: 23
# Configuration parameters: EnforcedStyle.
# SupportedStyles: annotated, template, unannotated
Style/FormatStringToken:
Exclude:
- 'lib/annotate/annotate_models.rb'
- 'lib/annotate/annotate_models/schema_info.rb'

# Offense count: 30
# Offense count: 32
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: when_needed, always, never
Expand All @@ -338,7 +283,7 @@ Style/HashSyntax:
- 'lib/tasks/annotate_routes.rake'
- 'spec/lib/annotate/annotate_models_spec.rb'

# Offense count: 7
# Offense count: 5
# Cop supports --auto-correct.
Style/IfUnlessModifier:
Exclude:
Expand Down Expand Up @@ -382,7 +327,7 @@ Style/NestedParenthesizedCalls:
Exclude:
- 'bin/annotate'

# Offense count: 3
# Offense count: 2
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
# SupportedStyles: predicate, comparison
Expand All @@ -392,7 +337,7 @@ Style/NumericPredicate:
- 'lib/annotate.rb'
- 'lib/annotate/annotate_models.rb'

# Offense count: 12
# Offense count: 7
# Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters:
Expand All @@ -401,7 +346,6 @@ Style/PercentLiteralDelimiters:
- 'lib/annotate/annotate_models.rb'
- 'lib/annotate/annotate_routes.rb'
- 'lib/tasks/annotate_models_migrate.rake'
- 'spec/lib/annotate/annotate_models_spec.rb'
- 'spec/lib/tasks/annotate_models_migrate_spec.rb'

# Offense count: 1
Expand All @@ -419,12 +363,6 @@ Style/RedundantBegin:
- 'lib/annotate/annotate_models.rb'
- 'spec/lib/annotate/annotate_models_spec.rb'

# Offense count: 1
# Cop supports --auto-correct.
Style/RedundantParentheses:
Exclude:
- 'lib/annotate/annotate_models.rb'

# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: AllowMultipleReturnValues.
Expand Down Expand Up @@ -461,13 +399,14 @@ Style/RescueStandardError:
Exclude:
- 'lib/annotate.rb'

# Offense count: 2
# Offense count: 3
# Cop supports --auto-correct.
# Configuration parameters: ConvertCodeThatCanStartToReturnNil, Whitelist.
# Whitelist: present?, blank?, presence, try, try!
Style/SafeNavigation:
Exclude:
- 'lib/annotate/annotate_models.rb'
- 'lib/annotate/annotate_models/schema_info.rb'

# Offense count: 15
# Cop supports --auto-correct.
Expand All @@ -477,7 +416,7 @@ Style/StderrPuts:
- 'lib/annotate.rb'
- 'lib/annotate/annotate_models.rb'

# Offense count: 55
# Offense count: 33
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
# SupportedStyles: single_quotes, double_quotes
Expand All @@ -491,14 +430,6 @@ Style/StringLiterals:
- 'spec/lib/annotate/annotate_models_spec.rb'
- 'spec/lib/annotate/parser_spec.rb'

# Offense count: 2
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: single_quotes, double_quotes
Style/StringLiteralsInInterpolation:
Exclude:
- 'lib/annotate/annotate_models.rb'

# Offense count: 8
# Cop supports --auto-correct.
# Configuration parameters: MinSize.
Expand All @@ -512,21 +443,13 @@ Style/SymbolLiteral:
Exclude:
- 'spec/lib/annotate/annotate_models_spec.rb'

# Offense count: 3
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyleForMultiline.
# SupportedStylesForMultiline: comma, consistent_comma, no_comma
Style/TrailingCommaInArrayLiteral:
Exclude:
- 'spec/lib/annotate/annotate_models_spec.rb'

# Offense count: 2
# Cop supports --auto-correct.
Style/UnneededPercentQ:
Exclude:
- 'annotate.gemspec'

# Offense count: 381
# Offense count: 394
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Expand Down
Loading