-
-
Notifications
You must be signed in to change notification settings - Fork 88
Remove more cyclic import dependencies #2076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks like my notebook.ts refactoring broke something but I do not yet understand the failure message:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks fine; left a pointer for how to fix your notebook issue
One challenge / annoyance will be getting typescript auto-import not to use barrels when it finds them. Otherwise these will just keep popping back up, and even with CI check it will be annoying to have to keep fixing them. There are some settings we can use to tune auto-import; maybe one of them can help us here
Did some research and I see microsoft/TypeScript#45953, which claims to have been solved by microsoft/TypeScript#47516, but that's not what I'm observing 🤔 cc/ @auscompgeek

packages/cursorless-vscode/src/ide/vscode/notebook/notebookLegacy.ts
Outdated
Show resolved
Hide resolved
@@ -40,5 +40,7 @@ export async function vscodeEditNewNotebookCellBelow( | |||
} | |||
|
|||
function isNotebookEditor(editor: VscodeTextEditorImpl) { | |||
return getNotebookFromCellDocument(editor.vscodeEditor.document) != null; | |||
return ( | |||
getNotebookFromCellDocumentCurrent(editor.vscodeEditor.document) != null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one needs to be fixed too
The Position/Range/Selection cycle is not touched. There are still some other cycles remaining as well, but this gets a lot of them.