Skip to content

[-] fix --group command-line option, closes #792 #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

pashagolub
Copy link
Collaborator

Rewrite Reaper.LoadSources to properly handle Groups. Drop SourceConns.SyncFromReader() as obsolete. Add TestReaper_LoadSources tests.

Rewrite `Reaper.LoadSources` to properly handle Groups. Drop
`SourceConns.SyncFromReader()` as obsolete. Add `TestReaper_LoadSources`
tests.
@pashagolub pashagolub self-assigned this Jun 10, 2025
@pashagolub pashagolub added bug Something isn't working sources What sources and in what way to monitor labels Jun 10, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15563934873

Details

  • 9 of 14 (64.29%) changed or added relevant lines in 2 files are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.6%) to 61.135%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/log/log.go 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
internal/sources/resolver.go 10 71.5%
Totals Coverage Status
Change from base Build 15561227899: 0.6%
Covered Lines: 2715
Relevant Lines: 4441

💛 - Coveralls

@pashagolub pashagolub merged commit b416138 into master Jun 11, 2025
9 checks passed
@pashagolub pashagolub deleted the 792-fix-group-cmdopts branch June 11, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sources What sources and in what way to monitor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants