Skip to content

Missing betterproto_lib_google_protobuf import if only used as rpc call parameter. #409

Open
@dries007

Description

@dries007

I'm using 2.0.0b5.

The following file results in broken python:

syntax = "proto3";

package experiment;

import "google/protobuf/empty.proto";

message Reply {
    bool happy = 1;
}

service Testcase {
  rpc call(google.protobuf.Empty) returns (Reply);
}

Specifically, the import import betterproto.lib.google.protobuf as betterproto_lib_google_protobuf is missing from the output file.

When any google.protobuf imported field is used anywhere else, it does work correctly, for example, the following files all work:

syntax = "proto3";

package experiment;

import "google/protobuf/empty.proto";

message Reply {
    bool happy = 1;
}

service Testcase {
  rpc call(Reply) returns (google.protobuf.Empty);
}
syntax = "proto3";

package experiment;

import "google/protobuf/empty.proto";

message Reply {
    bool happy = 1;
    google.protobuf.Empty e = 2;
}

service Testcase {
  rpc call(google.protobuf.Empty) returns (Reply);
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions